maropu commented on a change in pull request #30481:
URL: https://github.com/apache/spark/pull/30481#discussion_r537493806
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -937,6 +937,16 @@ object SQLConf {
.timeConf(TimeUnit.SECONDS)
.createWithDefault(0L)
+ val THRIFTSERVER_FORCE_CANCEL =
+ buildConf("spark.sql.thriftServer.forceCancel")
+ .doc("When true, all the job of query will be cancelled and running
tasks will be" +
+ "interrupted. When false, all the job of query will be cancelled but
running task" +
+ "will be remained until finished. Note that, this config must be set
before query" +
+ "otherwise it doesn't help.")
Review comment:
We need to describe `Note that, this config must be set before query
otherwise it doesn't help.` for this config? I think the other SQL configs have
the same restriction, too (users need to set a config before running a query).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
