imback82 commented on a change in pull request #30636:
URL: https://github.com/apache/spark/pull/30636#discussion_r537627495



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -1368,7 +1368,7 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
       sql("DROP VIEW dbx.tab1")
     }
     assert(
-      e.getMessage.contains("Cannot drop a table with DROP VIEW. Please use 
DROP TABLE instead"))
+      e.getMessage.contains("dbx.tab1 is a table. 'DROP VIEW' expects a 
view."))

Review comment:
       @cloud-fan do you think the message is regressing in terms of 
usefulness? One thing we can do is to introduce `hint: Option[String]` to 
`UnresolvedView` such that we can make the message as `dbx.tab1 is a table. 
'DROP VIEW' expects a view. Please use DROP TABLE instead.`. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to