Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/5116#issuecomment-93707209
Hey andrew, I have already updated the codes per your comment, but still
left one issue.
I think catching `SubmitRestConnectionException` in
`createSubmission/requestSubmissionStatus/killSubmission` is more reasonable
than in `readResponse` as we use `requestSubmissionStatus` to `Read the
response from the server and return it as a validated` and we submit requests
to multiple masters in
`createSubmission/requestSubmissionStatus/killSubmission` so we should take the
response there either.
Also i move the catching for ConnectionException into `postJson` in case
one master is down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
