sqlwindspeaker commented on pull request #30617: URL: https://github.com/apache/spark/pull/30617#issuecomment-741581727
> changes look fine. > > I assume you manually tested? Yes，but not fully。 This issue consist of 2 parts: hadoop ipc will raise InterruptedIOException, and InterruptedIOException should be handled correctly. I test part 2 by raising an InterruptedIOException in client.monitorApplication， but for part 1 I don't find a easy way to mock. But I believe the error trace is enough to show it will raise InterruptedIOException. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
