Victsm commented on a change in pull request #30433:
URL: https://github.com/apache/spark/pull/30433#discussion_r539082197
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -674,7 +683,10 @@ public void onComplete(String streamId) throws IOException
{
}
if (partitionInfo.getCurrentMapIndex() < 0) {
try {
- writeAnyDeferredBufs();
+ if (deferredBufs != null && !deferredBufs.isEmpty()) {
+ abortIfNecessary();
Review comment:
Why does this need to be inside the if block, instead of keeping
`writeDeferredBufs` as is and just calling `abortIfNecessary` before
`writeDeferredBufs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
