aokolnychyi commented on a change in pull request #29066:
URL: https://github.com/apache/spark/pull/29066#discussion_r539198823
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -261,3 +340,20 @@ private[sql] object FieldReference {
LogicalExpressions.parseReference(column)
}
}
+
+private[sql] final case class SortValue(
Review comment:
I am open to alternatives here for sure. It seems like we are giving
synonyms in this file. For example, `FieldReference` implements
`NamedReference`. Unfortunately, I cannot use `SortOrder` as it is already
taken in the public expression API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
