otterc commented on a change in pull request #30433:
URL: https://github.com/apache/spark/pull/30433#discussion_r539504808
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -674,7 +683,10 @@ public void onComplete(String streamId) throws IOException
{
}
if (partitionInfo.getCurrentMapIndex() < 0) {
try {
- writeAnyDeferredBufs();
+ if (deferredBufs != null && !deferredBufs.isEmpty()) {
+ abortIfNecessary();
Review comment:
I was thinking that if a stream is completing but doesn't need to write
any deferred bufs then we should let it complete without failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
