Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5537#issuecomment-93836401
Given that the network-common library (where the retry logic is) is
supposed to be generic, and not just for shuffle, I'd rather keep the retry
logic there, so this change looks better to me. I would just avoid setting the
value in the passed configuration, preferring to clone it instead (or some
other way that does not modify the input conf).
Perhaps a similar change in the non-YARN service (does that exist?) would
be needed too.
That being said, the javadoc for `TransportServer.bindRightPort` seems
wrong; it says it will try to bind to the given port multiple times, but it
actually tries different ports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
