dongjoon-hyun commented on a change in pull request #30700:
URL: https://github.com/apache/spark/pull/30700#discussion_r539845382
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala
##########
@@ -68,15 +69,24 @@ private[spark] object Minikube extends Logging {
def getKubernetesClient: DefaultKubernetesClient = {
val kubernetesMaster = s"https://${getMinikubeIp}:8443";
val userHome = System.getProperty("user.home")
+ val minikubeBasePath = Paths.get(userHome, MINIKUBE_PATH).toString
+ val profileDir = if (Files.exists(Paths.get(minikubeBasePath,
"apiserver.crt"))) {
+ // For Minikube <1.9
+ ""
+ } else {
+ // For Minikube >=1.9
+ val profile = executeMinikube("profile")(0)
+ Paths.get("profiles", profile).toString
Review comment:
Shall we simplify this?
```scala
- val profile = executeMinikube("profile")(0)
- Paths.get("profiles", profile).toString
+ Paths.get("profiles", executeMinikube("profile")(0)).toString
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
