cloud-fan commented on a change in pull request #30662:
URL: https://github.com/apache/spark/pull/30662#discussion_r539854837
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
##########
@@ -199,6 +199,33 @@ abstract class SQLViewTestSuite extends QueryTest with
SQLTestUtils {
}
}
}
+
+ test("SPARK-33692: view should use captured catalog and namespace to lookup
function") {
+ val avgFuncClass = "test.org.apache.spark.sql.MyDoubleAvg"
+ val sumFuncClass = "test.org.apache.spark.sql.MyDoubleSum"
+ val functionName = "test_udf"
+ withTempDatabase { dbName =>
+ withUserDefinedFunction(
+ s"default.$functionName" -> false,
+ s"$dbName.$functionName" -> false,
+ functionName -> true) {
+ // create a function in default database
+ sql("USE DEFAULT")
+ sql(s"CREATE FUNCTION $functionName AS '$avgFuncClass'")
+ // create a view using a function in 'default' database
+ val viewName = createView("v1", s"SELECT $functionName(col1) FROM
VALUES (1), (2), (3)")
+ // create function in another database with the same function name
+ sql(s"USE $dbName")
+ sql(s"CREATE FUNCTION $functionName AS '$sumFuncClass'")
+ // create temporary function with the same function name
+ sql(s"CREATE TEMPORARY FUNCTION $functionName AS '$sumFuncClass'")
+ withView(viewName) {
+ // view v1 should still using function defined in `default` database
+ checkViewOutput(viewName, Seq(Row(102.0)))
Review comment:
The avg should be `2.0`, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
