dongjoon-hyun commented on a change in pull request #30657:
URL: https://github.com/apache/spark/pull/30657#discussion_r539945362
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala
##########
@@ -100,11 +100,13 @@ package object client {
"org.apache.curator:*",
"org.pentaho:pentaho-aggdesigner-algorithm"))
- // Since HIVE-14496, Hive materialized view need calcite-core.
+ // Since HIVE-23980, calcite-core included in Hive package jar.
// For spark, only VersionsSuite currently creates a hive materialized
view for testing.
- case object v2_3 extends HiveVersion("2.3.7",
- exclusions = Seq("org.apache.calcite:calcite-druid",
+ case object v2_3 extends HiveVersion("2.3.8",
+ exclusions = Seq("org.apache.calcite:calcite-core",
+ "org.apache.calcite:calcite-druid",
"org.apache.calcite.avatica:avatica",
+ "com.google.guava:guava",
Review comment:
Just curious. Why do we need to exclude it? `Hive 2.3.8` is supposed to
shade it, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
