mridulm commented on a change in pull request #30433:
URL: https://github.com/apache/spark/pull/30433#discussion_r540262870
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -586,6 +592,7 @@ public void onData(String streamId, ByteBuffer buf) throws
IOException {
deferredBufs = null;
return;
}
+ abortIfNecessary();
Review comment:
I agree with @Ngone51 - if we failed on a previous write, there should
not be any subsequent writes: it will lead to inconsistent state (for example,
if previous write failed due to lack of space and subsequent write can go
through due to some async cleanup).
It is better to avoid these states rather than reason about them based on
current code state - as things evolve, it makes it more brittle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
