Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5544#discussion_r28567406
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -485,13 +485,16 @@ def join(self, other, joinExprs=None, joinType=None):
             return DataFrame(jdf, self.sql_ctx)
     
         @ignore_unicode_prefix
    -    def sort(self, *cols):
    +    def sort(self, *cols, **kwargs):
             """Returns a new :class:`DataFrame` sorted by the specified 
column(s).
     
    -        :param cols: list of :class:`Column` to sort by.
    +        :param cols: list of :class:`Column` or column names to sort by.
    +        :param ascending: sort by ascending order or not (default: True)
    --- End diff --
    
    we should explain what options are available for this, e.g. 'True', and 
list of ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to