maropu commented on a change in pull request #30709:
URL: https://github.com/apache/spark/pull/30709#discussion_r540606197
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -228,14 +228,21 @@ object SharedState extends Logging {
sparkConf: SparkConf,
hadoopConf: Configuration,
initialConfigs: scala.collection.Map[String, String] = Map.empty): Unit
= {
+
+ def containsInSparkConf(key: String): Boolean = {
+ sparkConf.contains(key) || sparkConf.contains("spark.hadoop." + key) ||
Review comment:
(This is not related to this PR though) The string prefix
`"spark.hadoop."` seems to be used in many places, so how about defining a
global value for it somewhere? I think that the refactoring could make it easy
to track the positions where the prefix is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
