southernriver opened a new pull request #30721:
URL: https://github.com/apache/spark/pull/30721


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   In order to facilitate the troubleshooting of hotspots or data skew, it's 
better to add more information like address and cost time on  
ShuffleBlockFetcherIterator.
   
   The new log are shown as below:
   
   > 2020-07-27 21:00:49,910 TRACE 
org.apache.spark.storage.ShuffleBlockFetcherIterator: Got remote block 
shuffle_1_39_5 from **hostname:7337** cost  **3511 ms**
   
   We can easily get the point that the current container cost **3511 ms** for 
getting remote block  from node **hostname:7337**.
   
   And the log would be printed  after 60s timeout.
   
   ### Why are the changes needed?
   Adding more comprehensive logs helps locate problems quickly.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   manual
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to