cloud-fan commented on a change in pull request #30479:
URL: https://github.com/apache/spark/pull/30479#discussion_r540712652
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2097,7 +2157,7 @@ case class UnBase64(child: Expression)
""",
since = "1.5.0")
// scalastyle:on line.size.limit
-case class Decode(bin: Expression, charset: Expression)
+case class StringDecode(bin: Expression, charset: Expression)
Review comment:
I'd suggest the following followup:
1. add a new function name for `StringDecode`. Probably "string_decode".
2. require `decode` function to take more than 2 parameters, under ansi
mode(or a legacy config)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
