HyukjinKwon commented on a change in pull request #30735:
URL: https://github.com/apache/spark/pull/30735#discussion_r540934212
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -836,21 +856,6 @@ private[spark] class SparkSubmit extends Logging {
(childArgs.toSeq, childClasspath.toSeq, sparkConf, childMainClass)
}
- private def renameResourcesToLocalFS(resources: String, localResources:
String): String = {
Review comment:
I read the codes multiple times for sure, and I think this code does a
duplicated job.
If I am not horribly wrong somewhere:
- `localResources` itself are always local files, and `resources` will
always be replaced to `localResources`.
- If `resources` is `null`, then `localResources` will be `null` too
cc @skonto from
https://github.com/apache/spark/commit/5e74570c8f5e7dfc1ca1c53c177827c5cea57bf1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
