HyukjinKwon commented on a change in pull request #30745:
URL: https://github.com/apache/spark/pull/30745#discussion_r541824686
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -706,6 +706,28 @@ object functions {
}
}
+ /**
+ * Aggregate function: returns the product of all numerical elements in a
group.
+ *
+ * @param scale A scaling constant to be multiplied into each non-null
value
+ * in the product, in order to provide some defence against
overflow.
+ * By default, this is set to one.
+ *
+ * @group agg_funcs
+ * @since 3.2.0
+ */
+ def product(e: Column, scale: Double = 1.0): Column =
Review comment:
`scale: Double = 1.0` -> let's don't use default value. It doesn't work
in Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
