tgravescs commented on pull request #30735: URL: https://github.com/apache/spark/pull/30735#issuecomment-744493629
overall approach looks fine to me, I didn't have time to do detailed review. I'm agree with deprecated config even if not used so users see warning. I see we changed the driver env settings here, how is executor pyspark being set? I took a very quick look and didn't see it in BasicExecutorFeatureStep. Just wondering if that needs to be updated at all. Especially if driver python path was different from executor ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
