HyukjinKwon commented on a change in pull request #30663:
URL: https://github.com/apache/spark/pull/30663#discussion_r543200132
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -184,7 +184,7 @@ class OrcFileFormat
Iterator.empty
} else {
// ORC predicate pushdown
- if (orcFilterPushDown) {
+ if (orcFilterPushDown && filters.nonEmpty) {
Review comment:
Can you do this in CSV, Avro and JSON filters too since we're here?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -184,7 +184,7 @@ class OrcFileFormat
Iterator.empty
} else {
// ORC predicate pushdown
- if (orcFilterPushDown) {
+ if (orcFilterPushDown && filters.nonEmpty) {
Review comment:
I meant to use `NoopFilters` to save a little bit of perf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
