HyukjinKwon commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r543278584
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -185,6 +185,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
RemoveLiteralFromGroupExpressions,
RemoveRepetitionFromGroupExpressions) :: Nil ++
operatorOptimizationBatch) :+
+ // This batch rewrites data source plans and should be run after the
operator
+ // optimization batch and before any batches that depend on stats.
+ Batch("Data Source Rewrite Rules", Once, dataSourceRewriteRules: _*) :+
Review comment:
@aokolnychyi, Are you saying a bad API is justified if users want?
I prefer to rename it in too. That's why I filed a blocker JIRA SPARK-33784
to keep this. I assigned this ticket to you.
To clarify again, I am suggesting to revert it in `branch-3.1` if we're in
deadlock because exposing a bad API is not a good idea as discussed and
documented in "Alternatives to Breaking an API" at
https://spark.apache.org/versioning-policy.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
