jbampton commented on a change in pull request #30776:
URL: https://github.com/apache/spark/pull/30776#discussion_r543286896
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java
##########
@@ -82,4 +82,27 @@ void createPartitions(
* @return true if partitions were deleted, false if any partition not exists
*/
boolean dropPartitions(InternalRow[] idents);
+
+ /**
+ * Drop an array of partitions atomically from table.
+ * <p>
+ * If any partition doesn't exists,
+ * the operation of dropPartitions need to be safely rolled back.
Review comment:
```suggestion
* the operation of dropPartitions needs to be safely rolled back.
```
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsAtomicPartitionManagement.java
##########
@@ -82,4 +82,27 @@ void createPartitions(
* @return true if partitions were deleted, false if any partition not exists
*/
boolean dropPartitions(InternalRow[] idents);
+
+ /**
+ * Drop an array of partitions atomically from table.
+ * <p>
+ * If any partition doesn't exists,
Review comment:
```suggestion
* If any partition doesn't exist,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
