srowen commented on a change in pull request #30784:
URL: https://github.com/apache/spark/pull/30784#discussion_r543522665
##########
File path: pom.xml
##########
@@ -3220,9 +3217,34 @@
<profile>
<id>scala-2.12</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
<build>
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>4.4.0</version>
+ <configuration>
+ <args combine.children="append">
+ <arg>-unchecked</arg>
+ <arg>-Xfatal-warnings</arg>
+ <arg>-deprecation</arg>
+ <arg>-Ywarn-unused-import</arg>
+ <arg>-P:silencer:globalFilters=.*deprecated.*</arg>
Review comment:
Do we need to silence deprecation here? that seems separate and a larger
step
##########
File path: pom.xml
##########
@@ -3243,6 +3265,32 @@
</dependency>
</dependencies>
</dependencyManagement>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>4.4.0</version>
Review comment:
You don't need to repeat the version
##########
File path: pom.xml
##########
@@ -2503,9 +2503,6 @@
<recompileMode>incremental</recompileMode>
<useZincServer>true</useZincServer>
<args>
- <arg>-unchecked</arg>
Review comment:
OK so the idea is we can't apply these to both 2.12 and 2.13? why not
`unchecked` though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
