aokolnychyi commented on a change in pull request #30806:
URL: https://github.com/apache/spark/pull/30806#discussion_r544396081
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -94,7 +96,8 @@ case class OverwriteByExpression(
deleteExpr: Expression,
query: LogicalPlan,
writeOptions: Map[String, String],
- isByName: Boolean) extends V2WriteCommand {
+ isByName: Boolean,
+ write: Option[Write] = None) extends V2WriteCommand {
Review comment:
Making this optional allows us to reuse the same plan before we
construct a write and after. Having `None` here means the logical write hasn't
been constructed yet. This allows us to have idempotent rules in the optimizer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
