luhenry commented on a change in pull request #30810:
URL: https://github.com/apache/spark/pull/30810#discussion_r544498951
##########
File path: mllib-local/pom.xml
##########
@@ -56,6 +56,11 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-tags_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.binary.version}</artifactId>
Review comment:
That is needed for two bits:
- `Utils.classForName`: a scalastyle rule indicated I should do that. I can
always disable the rule locally and use `Class.forName` directly.
- `Benchmark` and `BenchmarkBase`: I followed how
`org.apache.spark.mllib.linalg.UDTSerializationBenchmark` does it. Since that
is only for testing, is it an issue, or could that stay as-is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
