sunchao commented on a change in pull request #30806:
URL: https://github.com/apache/spark/pull/30806#discussion_r544508365
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V1FallbackWriters.scala
##########
@@ -38,10 +38,11 @@ case class AppendDataExecV1(
table: SupportsWrite,
writeOptions: CaseInsensitiveStringMap,
plan: LogicalPlan,
- refreshCache: () => Unit) extends V1FallbackWriters {
+ refreshCache: () => Unit,
+ override val write: Option[V1Write] = None) extends V1FallbackWriters {
- override protected def run(): Seq[InternalRow] = {
- writeWithV1(newWriteBuilder().buildForV1Write(), refreshCache =
refreshCache)
+ override protected def buildAndRun(): Seq[InternalRow] = {
Review comment:
I'm also +1 on getting rid of `buildAndRun`.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V1FallbackWriters.scala
##########
@@ -115,14 +131,10 @@ sealed trait V1FallbackWriters extends V2CommandExec with
SupportsV1Write {
trait SupportsV1Write extends SparkPlan {
def plan: LogicalPlan
- protected def writeWithV1(
- relation: InsertableRelation,
- refreshCache: () => Unit = () => ()): Seq[InternalRow] = {
+ protected def writeWithV1(relation: InsertableRelation): Seq[InternalRow] = {
val session = sqlContext.sparkSession
// The `plan` is already optimized, we should not analyze and optimize it
again.
relation.insert(AlreadyOptimized.dataFrame(session, plan), overwrite =
false)
- refreshCache()
Review comment:
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
