allisonwang-db commented on a change in pull request #30717:
URL: https://github.com/apache/spark/pull/30717#discussion_r544541217
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/QueryCompilationErrors.scala
##########
@@ -326,4 +340,164 @@ object QueryCompilationErrors {
"of rows, therefore they are currently not supported.", t.origin.line,
t.origin.startPosition)
}
+ def viewOutputNumberMismatchQueryColumnNamesError(
+ output: Seq[Attribute], queryColumnNames: Seq[String]): Throwable = {
+ new AnalysisException(
+ s"The view output ${output.mkString("[", ",", "]")} doesn't have the
same" +
+ "number of columns with the query column names " +
+ s"${queryColumnNames.mkString("[", ",", "]")}")
+ }
+
+ def attributeNotFoundError(colName: String, child: LogicalPlan): Throwable =
{
+ new AnalysisException(
+ s"Attribute with name '$colName' is not found in " +
+ s"'${child.output.map(_.name).mkString("(", ",", ")")}'")
+ }
+
+ def cannotUpCastAsAttributeTruncateError(
Review comment:
We can also remove "Truncate" in the method name here.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/QueryCompilationErrors.scala
##########
@@ -326,4 +340,165 @@ object QueryCompilationErrors {
"of rows, therefore they are currently not supported.", t.origin.line,
t.origin.startPosition)
}
+ def viewOutputNumberMismatchQueryColumnNamesError(
+ output: Seq[Attribute], queryColumnNames: Seq[String]): Throwable = {
+ new AnalysisException(
+ s"The view output ${output.mkString("[", ",", "]")} doesn't have the
same" +
+ "number of columns with the query column names " +
+ s"${queryColumnNames.mkString("[", ",", "]")}")
+ }
+
+ def attributeNotFoundError(colName: String, child: LogicalPlan): Throwable =
{
+ new AnalysisException(
+ s"Attribute with name '$colName' is not found in " +
+ s"'${child.output.map(_.name).mkString("(", ",", ")")}'")
+ }
+
+ def cannotUpCastAsAttributeTruncateError(
+ fromAttr: Attribute, toAttr: Attribute): Throwable = {
+ new AnalysisException(s"Cannot up cast ${fromAttr.sql} from " +
+ s"${fromAttr.dataType.catalogString} to ${toAttr.dataType.catalogString}
" +
+ "as it may truncate\n")
Review comment:
nit: no need `\n` in the end.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/QueryExecutionErrors.scala
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.errors
+
+import org.apache.spark.sql.catalyst.analysis.UnresolvedGenerator
+import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
+
+/**
+ * Object for grouping all error messages of the query runtime.
+ * Currently it includes all [[SparkException]]s and RuntimeExceptions(e.g.
+ * UnsupportedOperationException, IllegalStateException).
+ */
+object QueryExecutionErrors {
+
+ def columnChangeUnsupportedError(): Throwable = {
+ new UnsupportedOperationException("Please add an implementation for a
column change here")
+ }
+
+ def unexpectedPlanReturnError(other: LogicalPlan, methodName: String):
Throwable = {
Review comment:
nit: `other: LogicalPlan` -> `plan: LogicalPlan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
