viirya edited a comment on pull request #30770:
URL: https://github.com/apache/spark/pull/30770#issuecomment-747093389


   > Could you please elaborate the change? I see you're adding `lastAliveTime` 
and setting it, but never checking it. `stateStoreKeepAliveTime` isn't 
referenced anywhere. Did you miss adding some commit, and did you check the 
test is failing with latest master branch?
   
   Oops, <del>seems missing some commits.</del> I removed the change 
accidentally in last commit.
   
   BTW, the test is not failing in latest mater branch. I'm not sure if we can 
test if the state store provider is loaded after a certain time? Currently it 
checks if the provider is loaded by `eventually(time duration)`, but once it 
checks the provider is loaded, it will report success and finish this 
`eventually` block. What I want is to check after the duration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to