srowen commented on a change in pull request #30784:
URL: https://github.com/apache/spark/pull/30784#discussion_r544777960
##########
File path: pom.xml
##########
@@ -3220,9 +3217,33 @@
<profile>
<id>scala-2.12</id>
+ <activation>
Review comment:
What I mean is: you put 2.12's config outside a profile. 2.13's config
needs to replace it, and you can set this in the Maven XML a certain way to
prevent it from just appending, instead making it replace. Otherwise these args
won't be there at all for a 2.12 build where any profile is activated, without
activating the 2.12 profile explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
