kozakana commented on a change in pull request #30803:
URL: https://github.com/apache/spark/pull/30803#discussion_r545040023
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
##########
@@ -102,7 +102,7 @@ case class NaturalJoin(tpe: JoinType) extends JoinType {
}
case class UsingJoin(tpe: JoinType, usingColumns: Seq[String]) extends
JoinType {
- require(Seq(Inner, LeftOuter, LeftSemi, RightOuter, FullOuter,
LeftAnti).contains(tpe),
+ require(Seq(Inner, LeftOuter, LeftSemi, RightOuter, FullOuter, LeftAnti,
Cross).contains(tpe),
Review comment:
Does that mean it's better to modify the documentation?
[The join
document](https://spark.apache.org/docs/3.0.1/api/python/pyspark.sql.html#pyspark.sql.DataFrame.join)
says:
```
how – str, default inner. Must be one of: inner, cross, outer, full,
fullouter, full_outer, left, leftouter, left_outer, right, rightouter,
right_outer, semi, leftsemi, left_semi, anti, leftanti and left_anti.
```
It says that cross is configurable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
