AngersZhuuuu commented on a change in pull request #30824:
URL: https://github.com/apache/spark/pull/30824#discussion_r545522387
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3745,6 +3745,21 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
}
}
}
+
+ test("SPARK-33593: Parquet vector reader incorrect with binary partition
value") {
Review comment:
> Can you add a test case in
[f7d2143#diff-8e4e74b1869fecc81b75575bed45b183e79cbaa97578f42c51984c9d89ece45aR694](https://github.com/apache/spark/commit/f7d2143705c8c1baeed0bc62940f9dba636e705b#diff-8e4e74b1869fecc81b75575bed45b183e79cbaa97578f42c51984c9d89ece45aR694)
too?
Thanks for your advise, I am looking where to add UT for this since not
familiar with this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
