viirya commented on a change in pull request #30825:
URL: https://github.com/apache/spark/pull/30825#discussion_r545605782
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -266,12 +281,13 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
case AlterTable(catalog, ident, _, changes) =>
AlterTableExec(catalog, ident, changes) :: Nil
- case RenameTable(ResolvedTable(catalog, oldIdent, _), newIdent, isView) =>
+ case RenameTable(r @ ResolvedTable(catalog, oldIdent, _), newIdent,
isView) =>
if (isView) {
throw new AnalysisException(
"Cannot rename a table with ALTER VIEW. Please use ALTER TABLE
instead.")
}
- RenameTableExec(catalog, oldIdent, newIdent.asIdentifier) :: Nil
+ RenameTableExec(
+ catalog, oldIdent, newIdent.asIdentifier, invalidateCache(r), cache)
:: Nil
Review comment:
I think you need `recacheTable = true` to ask `invalidateCache` return
`CacheInfo`?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -52,21 +52,36 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
}
}
+ private def cache(relation: DataSourceV2Relation, cacheInfo: CacheInfo):
Unit = {
+ session.sharedState.cacheManager.cacheQuery(
+ session,
+ relation,
+ cacheInfo.tableName,
+ cacheInfo.storageLevel)
+ }
+
private def refreshCache(r: DataSourceV2Relation)(): Unit = {
session.sharedState.cacheManager.recacheByPlan(session, r)
}
- private def invalidateCache(r: ResolvedTable, recacheTable: Boolean =
false)(): Unit = {
+ // Invalidates the cache associated with the given table. If there exists a
cache with the given
+ // table, the cache's info (table name and storage level) is returned.
+ private def invalidateCache(
+ r: ResolvedTable,
+ recacheTable: Boolean = false)(): Option[CacheInfo] = {
val v2Relation = DataSourceV2Relation.create(r.table, Some(r.catalog),
Some(r.identifier))
val cache = session.sharedState.cacheManager.lookupCachedData(v2Relation)
session.sharedState.cacheManager.uncacheQuery(session, v2Relation, cascade
= true)
- if (recacheTable && cache.isDefined) {
- // save the cache name and cache level for recreation
+ if (cache.isDefined) {
val cacheName = cache.get.cachedRepresentation.cacheBuilder.tableName
val cacheLevel = cache.get.cachedRepresentation.cacheBuilder.storageLevel
Review comment:
`cacheName` and `cacheLevel` is needed only in `if (recacheTable) { ...
}` block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
