Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5574#discussion_r28646866
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1037,21 +1037,52 @@ private[spark] object Utils extends Logging {
}
/**
+ * Convert a passed byte string (e.g. 50b, 100kb, or 250mb) to bytes for
+ * internal use.
+ *
+ * If no suffix is provided, the passed number is assumed to be in bytes.
+ */
+ def byteStringAsBytes(str: String): Long = {
+ JavaUtils.byteStringAsBytes(str)
+ }
+
+ /**
+ * Convert a passed byte string (e.g. 50b, 100kb, or 250mb) to kilobytes
for
--- End diff --
Tough call. I like correctness; I do think people aren't used to seeing
`KiB`. They will probably figure it out quickly. I suppose it would help if
later we needed to add support for real kilobytes somewhere, since `KB` isn't
taken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
