HyukjinKwon commented on a change in pull request #30843:
URL: https://github.com/apache/spark/pull/30843#discussion_r546197326



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSQLInsertTestSuite.scala
##########
@@ -21,5 +21,23 @@ import org.apache.spark.sql.SQLInsertTestSuite
 import org.apache.spark.sql.hive.test.TestHiveSingleton
 
 class HiveSQLInsertTestSuite extends SQLInsertTestSuite with TestHiveSingleton 
{
+
+  private var originalPartitionMode = ""

Review comment:
       I think you can just use `null` instead of an empty string.
   
   ```
   private var originalPartitionMode: String = _
   ```
   
   here and
   
   ```scala
   spark.conf.get("hive.exec.dynamic.partition.mode", null)
   ```
   
   later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to