maropu commented on a change in pull request #30859:
URL: https://github.com/apache/spark/pull/30859#discussion_r546325475
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala
##########
@@ -107,12 +107,19 @@ package object debug {
*/
def codegenStringSeq(plan: SparkPlan): Seq[(String, String, ByteCodeStats)]
= {
val codegenSubtrees = new
collection.mutable.HashSet[WholeStageCodegenExec]()
- plan transform {
- case s: WholeStageCodegenExec =>
- codegenSubtrees += s
- s
- case s => s
+
+ def findSubtrees(plan: SparkPlan): Unit = {
+ plan transform {
+ case s: WholeStageCodegenExec =>
+ codegenSubtrees += s
Review comment:
The code below has the same issue?
https://github.com/apache/spark/blob/df2314b63aaf4992ac86ea0b68dae8554b066828/sql/core/src/test/scala/org/apache/spark/sql/BenchmarkQueryTest.scala#L65-L70
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
