maropu commented on a change in pull request #30859:
URL: https://github.com/apache/spark/pull/30859#discussion_r546362113
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/BenchmarkQueryTest.scala
##########
@@ -63,11 +63,17 @@ abstract class BenchmarkQueryTest extends QueryTest with
SharedSparkSession {
protected def checkGeneratedCode(plan: SparkPlan, checkMethodCodeSize:
Boolean = true): Unit = {
val codegenSubtrees = new
collection.mutable.HashSet[WholeStageCodegenExec]()
- plan foreach {
- case s: WholeStageCodegenExec =>
- codegenSubtrees += s
- case _ =>
+
+ def findSubtrees(paln: SparkPlan): Unit = {
Review comment:
Since this fix is not related to `EXPLAIN`, could you update the title
and the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
