kozakana commented on pull request #30803: URL: https://github.com/apache/spark/pull/30803#issuecomment-748600086
@HyukjinKwon `join` methods has ``` def join(right: Dataset[_], joinExprs: Column, joinType: String): DataFrame def join(right: Dataset[_], joinExprs: Column): DataFrame def join(right: Dataset[_], usingColumns: Seq[String], joinType: String): DataFrame def join(right: Dataset[_], usingColumns: Seq[String]): DataFrame def join(right: Dataset[_], usingColumn: String): DataFrame def join(right: Dataset[_]): DataFrame ``` [ref. org.apache.spark.sql.Dataset](https://spark.apache.org/docs/3.0.1/api/scala/org/apache/spark/sql/Dataset.html) `join` method always requires a column name. So it may have been implemented as `crossJoin`. And, I discovery [this comment](https://github.com/apache/spark/blob/8197ee3b15265d39f05f192934b7d7e661713eaa/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L993-L995). https://github.com/apache/spark/blob/8197ee3b15265d39f05f192934b7d7e661713eaa/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L993-L995 I suggest remove the cross option from the join method and use only the `crossJoin` method. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
