offthewall123 edited a comment on pull request #30831: URL: https://github.com/apache/spark/pull/30831#issuecomment-748606061
> Minor but fine, if we can deal with none of them being set correctly. Hi @srowen , i have considered of all of them is set uncorrectly, `join` actually handles this, and it will throw exception at higher method caller, here not add `if (firstJavaHome == null)` just to keep origin code logic. Anyway,have added it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
