cloud-fan commented on a change in pull request #30843:
URL: https://github.com/apache/spark/pull/30843#discussion_r546568729
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSQLInsertTestSuite.scala
##########
@@ -21,5 +21,20 @@ import org.apache.spark.sql.SQLInsertTestSuite
import org.apache.spark.sql.hive.test.TestHiveSingleton
class HiveSQLInsertTestSuite extends SQLInsertTestSuite with TestHiveSingleton
{
+
+ private val originalPartitionMode =
spark.conf.getOption("hive.exec.dynamic.partition.mode")
Review comment:
in sql/core, the `SparkSession` is created for each test suite, and we
can't use `spark` in the class constructor. In sql/hive it's OK as all test
suites share one global `SparkSession`, but let's avoid using this pattern that
only works in sql/hive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
