cloud-fan commented on a change in pull request #30806:
URL: https://github.com/apache/spark/pull/30806#discussion_r546737454
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -65,7 +66,8 @@ case class AppendData(
table: NamedRelation,
query: LogicalPlan,
writeOptions: Map[String, String],
- isByName: Boolean) extends V2WriteCommand {
+ isByName: Boolean,
+ write: Option[Write] = None) extends V2WriteCommand {
override def withNewQuery(newQuery: LogicalPlan): AppendData = copy(query =
newQuery)
override def withNewTable(newTable: NamedRelation): AppendData = copy(table
= newTable)
Review comment:
Shall we add `override lazy val resolved = ... && write.isDefined` in
`V2WriteCommand`? It's safer to make sure that the analyzer creates the `Write`
object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
