cloud-fan commented on a change in pull request #30443:
URL: https://github.com/apache/spark/pull/30443#discussion_r547251244
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##########
@@ -452,6 +453,16 @@ package object dsl {
def hint(name: String, parameters: Any*): LogicalPlan =
UnresolvedHint(name, parameters, logicalPlan)
+
+ def sample(
+ lowerBound: Double = 0.0,
+ upperBound: Double,
Review comment:
It's pretty weird that a parameter without default value comes after a
parameter with default value. If we want to follow Dataset, let's use
overloads. Otherwise, let's make this `sample` method simple and good enough
for the added tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
