cloud-fan commented on a change in pull request #30890:
URL: https://github.com/apache/spark/pull/30890#discussion_r547319108
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java
##########
@@ -173,26 +173,23 @@ Table alterTable(
boolean dropTable(Identifier ident);
/**
- * Drop a table in the catalog with an option to purge.
+ * Drop a table in the catalog and completely remove its data by skipping a
trash even if it is
+ * supported.
* <p>
* If the catalog supports views and contains a view for the identifier and
not a table, this
* must not drop the view and must return false.
* <p>
- * If the catalog supports the option to purge a table, this method must be
overridden.
- * The default implementation falls back to {@link #dropTable(Identifier)}
dropTable} if the
- * purge option is set to false. Otherwise, it throws {@link
UnsupportedOperationException}.
+ * If the catalog supports to purge a table, this method should be
overridden.
+ * The default implementation throws {@link UnsupportedOperationException}.
*
* @param ident a table identifier
- * @param purge whether a table should be purged
* @return true if a table was deleted, false if no table exists for the
identifier
+ * @throws UnsupportedOperationException If table purging is not supported
*
* @since 3.1.0
Review comment:
Yea, otherwise it's a breaking change and is not accepted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
