HyukjinKwon commented on a change in pull request #30484:
URL: https://github.com/apache/spark/pull/30484#discussion_r547339218
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
##########
@@ -94,47 +92,14 @@ public void initialize(InputSplit inputSplit,
TaskAttemptContext taskAttemptCont
Configuration configuration = taskAttemptContext.getConfiguration();
ParquetInputSplit split = (ParquetInputSplit)inputSplit;
this.file = split.getPath();
- long[] rowGroupOffsets = split.getRowGroupOffsets();
-
- ParquetMetadata footer;
- List<BlockMetaData> blocks;
-
- // if task.side.metadata is set, rowGroupOffsets is null
- if (rowGroupOffsets == null) {
Review comment:
Yeah, let's add an assert. That sounds like a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
