srowen commented on a change in pull request #30810:
URL: https://github.com/apache/spark/pull/30810#discussion_r547427103
##########
File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
##########
@@ -267,7 +282,7 @@ private[spark] object BLAS extends Serializable {
x: DenseVector,
beta: Double,
y: DenseVector): Unit = {
- f2jBLAS.dspmv("U", n, alpha, A.values, x.values, 1, beta, y.values, 1)
+ javaBLAS.dspmv("U", n, alpha, A.values, x.values, 1, beta, y.values, 1)
Review comment:
OK that's fine if we're fairly confident that this is a win for this use
case. I don't even know if there was a strong reason for it or whether it's
still valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
