Ngone51 commented on pull request #30795: URL: https://github.com/apache/spark/pull/30795#issuecomment-749901693
> ...since you changed the definition of executorCountWithResourceProfile to not include the excluded nodes, if the excluded nodes idle timeout we could be keeping around those excluded nodes. ie min=3, we have 5 active and 2 are excluded., we think only 3 so the 2 are never removed. ... Yea. I have mentioned this issue in the PR description. In this case, the better way is to remove excluded executors first. I thought it could be a follow-up if this PR gets approved. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
