LuciferYang commented on a change in pull request #30784:
URL: https://github.com/apache/spark/pull/30784#discussion_r547696033
##########
File path: pom.xml
##########
@@ -3243,6 +3253,39 @@
</dependency>
</dependencies>
</dependencyManagement>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <configuration>
+ <args>
+ <arg>-unchecked</arg>
Review comment:
if we set `<args combine.children="append">` in Scala 2.13, the
effective pom will be
```
<args combine.children="append">
<arg>-unchecked</arg>
<arg>-deprecation</arg>
<arg>-feature</arg>
<arg>-explaintypes</arg>
<arg>-target:jvm-1.8</arg>
<arg>-Xfatal-warnings</arg>
<arg>-Ywarn-unused:imports</arg>
<arg>-P:silencer:globalFilters=.*deprecated.*</arg>
<arg>-Wconf:cat=deprecation:wv,any:e</arg>
...
```
The are 3 flags shouldn't be in Scala 2.13
- `-P:silencer:globalFilters=.*deprecated.*`: This is the compilation option
for `silencer-plugin`, compilation will fail because this plugin does not exist
in Scala 2.13
- `-Xfatal-warnings` and `-Ywarn-unused:imports`: `unused-imports` check not
enabled in Scala 2.13, compilation will fail because
scala.language.higherKinds no longer needs to be imported explicitly since
Scala 2.13.1. Or need to add rules to suppress them.
So I think we may need to keep these duplicate flags here, or I haven't
thought of an effective way yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
