dongjoon-hyun commented on a change in pull request #30892:
URL: https://github.com/apache/spark/pull/30892#discussion_r547917904
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
##########
@@ -96,6 +97,11 @@ private[spark] class KubernetesClusterManager extends
ExternalClusterManager wit
ExecutorPodsSnapshot.setShouldCheckAllContainers(
sc.conf.get(KUBERNETES_EXECUTOR_CHECK_ALL_CONTAINERS))
+ val sparkContainerName =
sc.conf.get(KUBERNETES_EXECUTOR_PODTEMPLATE_CONTAINER_NAME).getOrElse(
+ DEFAULT_EXECUTOR_CONTAINER_NAME)
+ ExecutorPodsSnapshot.setSparkContainerName(
+ sparkContainerName
+ )
Review comment:
In this case, one liner will be better.
```scala
ExecutorPodsSnapshot.setSparkContainerName(sparkContainerName)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
