dongjoon-hyun commented on a change in pull request #30864:
URL: https://github.com/apache/spark/pull/30864#discussion_r548324797
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -83,14 +87,13 @@ trait ExpressionWithRandomSeed {
""",
since = "1.5.0")
// scalastyle:on line.size.limit
-case class Rand(child: Expression, hideSeed: Boolean = false)
- extends RDG with ExpressionWithRandomSeed {
+case class Rand(child: Expression, hideSeed: Boolean = false) extends RDG {
- def this() = this(Literal(Utils.random.nextLong(), LongType), true)
+ def this() = this(UnresolvedSeed, true)
def this(child: Expression) = this(child, false)
- override def withNewSeed(seed: Long): Rand = Rand(Literal(seed, LongType))
+ override def withNewSeed(seed: Long): Rand = Rand(Literal(seed, LongType),
hideSeed)
Review comment:
Ur, is this related to this PR, @ulysses-you ? This looks like an
orthogonal bug fix a little to me. I'm wondering if we we have a test coverage
for this.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -134,14 +137,13 @@ object Rand {
""",
since = "1.5.0")
// scalastyle:on line.size.limit
-case class Randn(child: Expression, hideSeed: Boolean = false)
- extends RDG with ExpressionWithRandomSeed {
+case class Randn(child: Expression, hideSeed: Boolean = false) extends RDG {
- def this() = this(Literal(Utils.random.nextLong(), LongType), true)
+ def this() = this(UnresolvedSeed, true)
def this(child: Expression) = this(child, false)
- override def withNewSeed(seed: Long): Randn = Randn(Literal(seed, LongType))
+ override def withNewSeed(seed: Long): Randn = Randn(Literal(seed, LongType),
hideSeed)
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
