LuciferYang commented on a change in pull request #30484:
URL: https://github.com/apache/spark/pull/30484#discussion_r548367035



##########
File path: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
##########
@@ -93,48 +93,17 @@ public void initialize(InputSplit inputSplit, 
TaskAttemptContext taskAttemptCont
       throws IOException, InterruptedException {
     Configuration configuration = taskAttemptContext.getConfiguration();
     ParquetInputSplit split = (ParquetInputSplit)inputSplit;
+    Preconditions.checkState(split.getRowGroupOffsets() == null,

Review comment:
       For the current spark code, I think `split.getRowGroupOffsets()` should 
always be null because after SPARK-13883 and SPARK-13989 `ParquetInputSplit`  
is created manually in `ParquetRelation(ParquetFileFormat) ` and  set 
`rowGroupOffsets` to null explicitly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to