maropu commented on a change in pull request #30922:
URL: https://github.com/apache/spark/pull/30922#discussion_r548819529
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1362,17 +1363,17 @@ private[spark] object SparkSubmitUtils {
* @param ivySettings An IvySettings containing resolvers to use
* @param transitive Whether resolving transitive dependencies, default is
true
* @param exclusions Exclusions to apply when resolving transitive
dependencies
- * @return The comma-delimited path to the jars of the given maven artifacts
including their
+ * @return Seq of path to the jars of the given maven artifacts including
their
* transitive dependencies
*/
def resolveMavenCoordinates(
coordinates: String,
ivySettings: IvySettings,
transitive: Boolean,
exclusions: Seq[String] = Nil,
- isTest: Boolean = false): String = {
+ isTest: Boolean = false): Seq[String] = {
if (coordinates == null || coordinates.trim.isEmpty) {
- ""
+ Seq.empty[String]
Review comment:
nit: Nil?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
